Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made oop and functional API same #3408

Merged
merged 1 commit into from Mar 18, 2023
Merged

made oop and functional API same #3408

merged 1 commit into from Mar 18, 2023

Conversation

ngupta23
Copy link
Collaborator

Related Issue or bug

Closes #3405

Describe the changes you've made

Change was made to oop interface already, but missed making it to functional API earlier. This change has been made now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests to pass on GitHub CI.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 linked an issue Mar 18, 2023 that may be closed by this pull request
3 tasks
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Mar 18, 2023
@ngupta23 ngupta23 added this to the pycaret 3.0.0 milestone Mar 18, 2023
@ngupta23 ngupta23 added time_series Topics related to the time series load_models save_model and removed load_models labels Mar 18, 2023
@moezali1 moezali1 merged commit 2704229 into master Mar 18, 2023
13 of 14 checks passed
Time Series Forecasting automation moved this from In progress to Done Mar 18, 2023
@ngupta23 ngupta23 deleted the 3405-ts_save_model branch March 19, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
save_model time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

[BUG]: change default of model_only in save_model in time_series module
2 participants