Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to static renderer to save space #3409

Merged
merged 1 commit into from Mar 18, 2023
Merged

switched to static renderer to save space #3409

merged 1 commit into from Mar 18, 2023

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Mar 18, 2023

Related Issue or bug

Time Series tutorial notebooks not rendering on nbviewer. Probably due to size of notebooks (some are over 50MB due to interactive plots)

Describe the changes you've made

Switched to a static png renderer to save space. Size < 10MB on all notebooks now. This is working now

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests to pass on GH

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested a review from moezali1 March 18, 2023 01:44
@ngupta23 ngupta23 added documentation Improvements or additions to documentation time_series Topics related to the time series labels Mar 18, 2023
@ngupta23 ngupta23 added this to In progress in Time Series Forecasting via automation Mar 18, 2023
@ngupta23 ngupta23 added this to the pycaret 3.0.0 milestone Mar 18, 2023
@ngupta23 ngupta23 requested review from tvdboom, Yard1 and moezali1 and removed request for moezali1 March 18, 2023 01:55
@moezali1 moezali1 merged commit a6805bb into master Mar 18, 2023
13 of 14 checks passed
Time Series Forecasting automation moved this from In progress to Done Mar 18, 2023
@Yard1 Yard1 deleted the ts_notebooks branch March 18, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation time_series Topics related to the time series
Development

Successfully merging this pull request may close these issues.

None yet

2 participants