Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TBATS issues on M3 dataset #3478

Merged
merged 10 commits into from Apr 23, 2023
Merged

Fix for TBATS issues on M3 dataset #3478

merged 10 commits into from Apr 23, 2023

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Apr 16, 2023

Related Issue or bug

Describe the changes you've made

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally tested, GitHub regression tests should pass

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 changed the title temporary fix for #3233 Fix for TBATS issues on M3 dataset Apr 16, 2023
@ngupta23 ngupta23 requested a review from Yard1 April 21, 2023 18:44
@ngupta23 ngupta23 merged commit 87f398b into master Apr 23, 2023
13 of 14 checks passed
@ngupta23 ngupta23 deleted the fix_tbats branch April 23, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Update TBATS version [ENH]: TBATS does not work well for certain datasets
2 participants