Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groups and pipelines that alter number of rows #3629

Merged
merged 10 commits into from Jul 10, 2023
Merged

Fix groups and pipelines that alter number of rows #3629

merged 10 commits into from Jul 10, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented Jul 4, 2023 •
edited

Related Issue or bug

Closes #3588
Closes #3632

Describe the changes you've made

  • Fix a bug with group_features. Also, remove the group_names parameter and make group_features a dict where the key is the group name.
  • Fix a bug where create_model and predict_model would fail for pipelines that altered the number of rows.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested a review from Yard1 July 4, 2023 10:55
@tvdboom tvdboom requested a review from ngupta23 July 4, 2023 12:45
@tvdboom tvdboom mentioned this pull request Jul 7, 2023
Closed
3 tasks
@tvdboom tvdboom changed the title Fix groups Fix groups and pipelines that alter number of rows Jul 7, 2023
Yard1
Yard1 reviewed Jul 9, 2023
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. 2 comments regarding monkey patching

pycaret/utils/patches.py Outdated Show resolved Hide resolved
pycaret/internal/pycaret_experiment/supervised_experiment.py Show resolved Hide resolved
@tvdboom tvdboom merged commit fa8cb5e into master Jul 10, 2023
8 of 14 checks passed
@tvdboom tvdboom deleted the fix_groups branch July 10, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@ngupta23 ngupta23 Awaiting requested review from ngupta23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Numeric imputation "drop" [BUG]: nested group_features with unequally sized groups
2 participants
@tvdboom @Yard1