Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xgboost v2 and restrict Python versions #3749

Merged
merged 20 commits into from Nov 10, 2023

Conversation

celestinoxp
Copy link
Contributor

Related Issue or bug

Info about Issue or bug

Closes #[issue number that will be closed through this PR]

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

This change is to avoid problems with versions of Python that are no longer supported such as Python 3.7
fix bug, now accept python 3.10.x
This change is to avoid problems with versions of Python that are no longer supported such as Python 3.7
fix bug, now accept python 3.10.x
simplify version checks
i installed flake8 in vscode
some changes to support xgboost 2.0 and higher
@tvdboom tvdboom changed the title Update xgboost v2 Update xgboost v2 and restrict Python versions Sep 24, 2023
Copy link
Collaborator

@tvdboom tvdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in pycaret/containers/models/classification.py should also be made in the regression and forecast modules.

pycaret/__init__.py Outdated Show resolved Hide resolved
pycaret/__init__.py Outdated Show resolved Hide resolved
pycaret/containers/models/classification.py Outdated Show resolved Hide resolved
pycaret/containers/models/classification.py Outdated Show resolved Hide resolved
pycaret/__init__.py Outdated Show resolved Hide resolved
chabges recommended by @tvdboom
@tvdboom
Copy link
Collaborator

tvdboom commented Sep 28, 2023

Please, also change xgboost in the file pycaret/containers/models/time_series.py.

Also, the test failing you mentioned in #3750 is fixed in #3756. If that PR goes through (depending on tests), you should change the required versions to accept 3.11

@tvdboom
Copy link
Collaborator

tvdboom commented Nov 8, 2023

Hi @celestinoxp, #3756 is going to go through soon (this week probably) so we can add support for 3.11 as well

celestinoxp and others added 2 commits November 8, 2023 19:04
pycaret now should support python 3.8, 3.9, 3.10, 3.11 else show error to upgrade or downgrade
@celestinoxp
Copy link
Contributor Author

Hi @celestinoxp, #3756 is going to go through soon (this week probably) so we can add support for 3.11 as well

Hi. support for python 3.11 added.
It is possible that more modifications to the code regarding xgboost will be necessary, but perhaps it would be better to add other pull-requests in the future... my experience is little and it would be good if the pycaret team was more active in order to help. You can change my commits at will, I activated the option "Allow edits by maintainers"

Copy link
Collaborator

@tvdboom tvdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thx for the contribution.

@tvdboom tvdboom merged commit 342c79d into pycaret:master Nov 10, 2023
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants