Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to non-positional explicit args and kwargs to catch them #3801

Merged
merged 1 commit into from Oct 28, 2023

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Oct 28, 2023

Related Issue or bug

Closes #3789

Describe the changes you've made

  • Changes some calls to include explicit args
  • used kwargs to catch unused args in TS function definition

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests pass locally (some basic ones), rest all to pass in GH

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Oct 28, 2023
@ngupta23 ngupta23 added this to the 3.1.1 milestone Oct 28, 2023
@ngupta23 ngupta23 mentioned this pull request Oct 28, 2023
13 tasks
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Yard1 Yard1 merged commit b49613b into master Oct 28, 2023
12 checks passed
@Yard1 Yard1 deleted the ts_fix_issues_caused_by_base_change branch October 28, 2023 18:59
@ngupta23 ngupta23 modified the milestones: 3.1.1, 3.2.0 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: all tests are failing
2 participants