Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Hardcoded distribute path to PyPi should be removed #212

Closed
gdmka opened this issue Aug 1, 2013 · 6 comments
Closed

Hardcoded distribute path to PyPi should be removed #212

gdmka opened this issue Aug 1, 2013 · 6 comments

Comments

@gdmka
Copy link

gdmka commented Aug 1, 2013

Greets! We use autoindex to mirror project dependencies to private server, among them there's pycassa.

When a person tries to install pycassa from private mirror using pip, pycassa tries to fetch distribute dependency from the official PyPi repo and it doesn't look the index url provided by pip.

The proposal is to add distribute along thrift in install_requires so pip could download it from a private mirror.
Or if a client passes -e or -i flags to pip, pycassa will try to find distribute there.

@thobbs
Copy link
Member

thobbs commented Aug 12, 2013

Hmm, I'm not sure that the setuptools/ez_setup stuff even needs to be kept around. I think the normal distutils setup() function should be fine. Would that fix the issue for you?

@gdmka
Copy link
Author

gdmka commented Aug 13, 2013

You're absolutely right. There is no need in use_setuptools() and DEFAULT_URL found in setuptools/ez_setup at all.

The dependencies can be resolved in setup.py using install_requires. Moreover, the hardcoded distribute version is quite old 0.6.14 while the fresh one is 0.7.3. So answering your question, yes.

thobbs added a commit that referenced this issue Aug 13, 2013
This should potentially resolve #212
@thobbs
Copy link
Member

thobbs commented Aug 13, 2013

Actually, I think it may be a better option to switch to Distribute. I believe it supports the options you need to use a private mirror. Can you try out the distribute branch and let me know if that works for you?

@gdmka
Copy link
Author

gdmka commented Aug 23, 2013

Yeah, this works! I hope you will merge the branch and release new package for PyPi. Thanks!

@gdmka gdmka closed this as completed Sep 25, 2013
@kholia
Copy link

kholia commented Oct 27, 2013

@thobbs

I am trying to package pycassa for Fedora. It would be great if you could merge the distribute branch into master and release a new pycassa version.

@gdmka gdmka reopened this Oct 27, 2013
@thobbs
Copy link
Member

thobbs commented Jan 14, 2014

@kholia @gdmka given that the Distribute fork of setuptools has been merged back in, I've decided to stick with setuptools and ez_setup.py, which I upgraded here: c841381

The 1.11.0 release includes this change.

Thanks!

@thobbs thobbs closed this as completed Jan 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants