Skip to content

Commit

Permalink
Improve Windows install (#1817)
Browse files Browse the repository at this point in the history
In the Windows installation, do not use the `sleep` command to wait for
an executable to finish, as this leads to random crashes. Instead, use
the proper Windows commands (taken from PR #1180) to wait for the
execution.
  • Loading branch information
EmilyBourne committed Apr 9, 2024
1 parent b39fe9a commit f657701
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/actions/windows_install/action.yml
Expand Up @@ -52,10 +52,8 @@ runs:
curl https://github.com/microsoft/Microsoft-MPI/releases/download/v10.1.1/msmpisdk.msi -o msmpisdk.msi
#
# Install MS MPI
./msmpisetup.exe -unattend -verbose
sleep 30
msiexec /quiet /i msmpisdk.msi
sleep 1
Start-Process msmpisetup.exe -Wait -ArgumentList '-unattend -verbose'
Start-Process msiexec -Wait -ArgumentList '/quiet /i msmpisdk.msi'
echo "MS MPI runtime and SDK installed"
shell: powershell
- name: Setup MPI
Expand Down

0 comments on commit f657701

Please sign in to comment.