Improve Windows install #1817
Merged
Improve Windows install #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
|
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
|
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
smazouz42
approved these changes
Apr 5, 2024
pyccel-bot
bot
added
Ready_for_review
|
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @smazouz42 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄 |
EmilyBourne
added
the
internals
yguclu
approved these changes
Apr 9, 2024
pyccel-bot
bot
added
Ready_to_merge
EmilyBourne
added a commit
that referenced
this pull request
May 6, 2024
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution.
EmilyBourne
added a commit
that referenced
this pull request
May 7, 2024
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows installation uses a
sleepcommand because we were unsure how to wait for the executable to finish and also prevent it from asking the user for input. This probably leads to the CI being slower than necessary and definitely occasionally leads to the CI crashing when the executable takes longer than we hoped. This PR is derived from #1180 where I found the necessary commands to wait for the execution.