Fix review status #1473
Fix review status #1473
Conversation
EmilyBourne
added
urgent
|
Hello again! Thank you for this new pull request 🤩. Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
|
It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with |
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
|
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
pyccel-bot
bot
added
Ready_for_review
|
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @sboof911 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄 |
|
/bot run pr_tests |
pyccel-bot
bot
added
Ready_for_review
|
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @sboof911 think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄 |
pyccel-bot
bot
added
Ready_to_merge
By default the GitHub API only returns the first 30 reviews. This PR changes that so it collects 100 reviews per page and keeps collecting pages until there are none left. With all the reviews the bot can make a correct decision on whether a review should be re-requested and what is the review state of a PR.
Additionally ci_tools/bot_clean_up.py is modified to avoid duplicating code.
This PR was tested in my fork,