-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anaconda_windows problems #1481
Conversation
Hello again! Thank you for this new pull request 🤩. Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
/bot run anaconda_windows |
da7fc3d
to
b6752e4
Compare
/bot run anaconda_windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with |
/bot commands |
This bot reacts to all comments which begin with
Beware: if you have never contributed to this repository and you are not a member of the Pyccel organisation, the bot will ignore all requests to run tests until permitted by a trusted reviewer. |
/bot show tests |
The following is a list of keywords which can be used to run tests. Tests in bold are run by pull requests when they are marked as ready for review or pushed to while not in draft:
These tests can be run with the command |
/bot run macosx |
Fix the shell command to ensure the Python installed by anaconda is used for posting results. Reorder the setup so pip is called after conda (conda does not check pip dependencies). Fixes #1480