Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anaconda_windows problems #1481

Merged
merged 8 commits into from
Aug 13, 2023
Merged

Fix anaconda_windows problems #1481

merged 8 commits into from
Aug 13, 2023

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented Aug 8, 2023

Fix the shell command to ensure the Python installed by anaconda is used for posting results. Reorder the setup so pip is called after conda (conda does not check pip dependencies). Fixes #1480

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 8, 2023

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne
Copy link
Member Author

/bot run anaconda_windows

@EmilyBourne EmilyBourne linked an issue Aug 8, 2023 that may be closed by this pull request
@EmilyBourne
Copy link
Member Author

/bot run anaconda_windows

@EmilyBourne EmilyBourne changed the title Fix devel run problems Fix anaconda_windows problems Aug 8, 2023
@EmilyBourne EmilyBourne added the Bot label Aug 8, 2023
@EmilyBourne EmilyBourne marked this pull request as ready for review August 8, 2023 10:11
@EmilyBourne EmilyBourne marked this pull request as draft August 8, 2023 10:13
@EmilyBourne EmilyBourne marked this pull request as ready for review August 8, 2023 10:13
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 8, 2023

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@EmilyBourne EmilyBourne requested a review from a team August 11, 2023 06:48
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed needs_initial_review labels Aug 13, 2023
@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@github-actions github-actions bot marked this pull request as draft August 13, 2023 17:09
@pyccel-bot pyccel-bot bot removed the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Aug 13, 2023
@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot commands

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

This bot reacts to all comments which begin with /bot. This phrase can be followed by any of these commands:

  • show tests : Lists the tests which can be triggered
  • run X : Triggers the test X (acceptable values for X can be seen using show tests). Multiple tests can be specified separated by spaces.
  • try V X : Triggers the test X (acceptable values for X can be seen using show tests) using Python version V. Multiple tests can be specified separated by spaces, but all will use the same Python version.
  • mark as ready : Runs the PR tests. If they pass then it adds the appropriate review flag and requests reviews. This command should be used when the PR is first ready for review, or when a review has been answered.
  • commands : Shows this list detailing all the commands which are understood.
  • trust user X : Tells the bot that a new user X is trusted to run workflows (prevents misuse of GitHub actions for mining etc). This command can only be used by a trusted reviewer.
  • accept coverage : Tells the bot that the coverage errors have been investigated and cannot be fixed in this PR.

Beware: if you have never contributed to this repository and you are not a member of the Pyccel organisation, the bot will ignore all requests to run tests until permitted by a trusted reviewer.

@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot show tests

@pyccel-bot
Copy link

pyccel-bot bot commented Aug 13, 2023

The following is a list of keywords which can be used to run tests. Tests in bold are run by pull requests when they are marked as ready for review or pushed to while not in draft:

  • linux : Runs the unit tests on a Linux system.
  • windows : Runs the unit tests on a Windows system.
  • macosx : Runs the unit tests on a MacOS X system.
  • coverage : Runs the unit tests on a Linux system and checks the coverage of the tests.
  • docs : Checks if the documentation follows the numpydoc format.
  • pylint : Runs pylint on files which are too big to be handled by codacy.
  • pyccel_lint : Runs a linter to check that Pyccel's best practices are followed.
  • spelling : Checks if everything in the documentation is spelled (and capitalised) correctly.
  • pr_tests : Runs all the tests marked in bold.
  • pickle : Checks that .pyccel files have been correctly generated and installed by the installation process.
  • editable_pickle : Checks that .pyccel files have been correctly generated and installed by the editable installation process.
  • pickle_wheel : Checks that .pyccel files have been correctly generated and packaged into the wheel.
  • linux_anaconda : Runs the unit tests on a linux system using anaconda for python.
  • windows_anaconda : Runs the unit tests on a windows system using anaconda for python.

These tests can be run with the command /bot run X (multiple tests can be specified separated by spaces), or with try V X to test on Python version V.

@yguclu
Copy link
Member

yguclu commented Aug 13, 2023

/bot run macosx

@EmilyBourne EmilyBourne marked this pull request as ready for review August 13, 2023 17:41
@pyccel-bot pyccel-bot bot added the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Aug 13, 2023
@yguclu yguclu merged commit d67a6ba into devel Aug 13, 2023
11 checks passed
@yguclu yguclu deleted the devel-issue1480 branch August 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BOT] Anaconda windows test not reporting
2 participants