Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some Pylint fixes : Part 1 #1591

Merged
merged 15 commits into from
Nov 3, 2023

Merge branch 'devel' into bitwise_docstrings

29d7e7f
Select commit
Loading
Failed to load commit list.
Merged

Apply some Pylint fixes : Part 1 #1591

Merge branch 'devel' into bitwise_docstrings
29d7e7f
Select commit
Loading
Failed to load commit list.
Pyccel Bot / Pyccel best practices (pyccel_lint, 3.8) succeeded Nov 3, 2023 in 1m 1s

Pyccel Linting

Check Slots:

Non-alphabetical __all__ :

  • pyccel.ast.literals

  • pyccel.ast.core

  • pyccel.ast.class_defs

  • pyccel.ast.sympy_helper

  • pyccel.ast.type_annotations

  • pyccel.ast.builtins

  • pyccel.ast.omp

  • pyccel.ast.numpy_wrapper

  • pyccel.ast.basic

  • pyccel.ast.numpyext

  • pyccel.ast.mathext

  • pyccel.ast.operators

  • pyccel.ast.datatypes

  • pyccel.ast.bitwise_operators

  • pyccel.ast.cmathext

  • pyccel.ast.cwrapper

Classes missing from __all__ :

  • pyccel.ast.bind_c.BindCClassDef

  • pyccel.ast.cwrapper.PyClassDef

Pylint Interaction:

  • Unexpected pylint disables found in tests/ndarrays/conftest.py: arguments-differ, inconsistent-return-statements, protected-access, abstract-method

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dger.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dgemv.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dgemm.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dscal.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dswap.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_dcopy.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/blas/runtest_daxpy.py: undefined-variable, unused-import

  • Unexpected pylint disables found in tests/macro/scripts/lapack/runtest_dgbtrf.py: undefined-variable, unused-import

Annotations

Check warning on line 26 in pyccel/ast/literals.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/literals.py#L13-L26

Sort the __all__ attribute of `literals`

Check warning on line 94 in pyccel/ast/core.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/core.py#L36-L94

Sort the __all__ attribute of `core`

Check warning on line 25 in pyccel/ast/class_defs.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/class_defs.py#L17-L25

Sort the __all__ attribute of `class_defs`

Check warning on line 27 in pyccel/ast/sympy_helper.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/sympy_helper.py#L26-L27

Sort the __all__ attribute of `sympy_helper`

Check warning on line 23 in pyccel/ast/type_annotations.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/type_annotations.py#L18-L23

Sort the __all__ attribute of `type_annotations`

Check warning on line 55 in pyccel/ast/builtins.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/builtins.py#L30-L55

Sort the __all__ attribute of `builtins`

Check warning on line 31 in pyccel/ast/omp.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/omp.py#L15-L31

Sort the __all__ attribute of `omp`

Check warning on line 44 in pyccel/ast/numpy_wrapper.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/numpy_wrapper.py#L31-L44

Sort the __all__ attribute of `numpy_wrapper`

Check warning on line 116 in pyccel/ast/numpyext.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/numpyext.py#L41-L116

Sort the __all__ attribute of `numpyext`

Check warning on line 73 in pyccel/ast/mathext.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/mathext.py#L15-L73

Sort the __all__ attribute of `mathext`

Check warning on line 61 in pyccel/ast/operators.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/operators.py#L31-L61

Sort the __all__ attribute of `operators`

Check warning on line 57 in pyccel/ast/datatypes.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/datatypes.py#L18-L57

Sort the __all__ attribute of `datatypes`

Check warning on line 26 in pyccel/ast/bitwise_operators.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/bitwise_operators.py#L17-L26

Sort the __all__ attribute of `bitwise_operators`

Check warning on line 46 in pyccel/ast/cmathext.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/cmathext.py#L21-L46

Sort the __all__ attribute of `cmathext`

Check warning on line 56 in pyccel/ast/cwrapper.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/cwrapper.py#L35-L56

Sort the __all__ attribute of `cwrapper`

Check failure on line 544 in pyccel/ast/bind_c.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/bind_c.py#L544

`bind_c.BindCClassDef` is missing from `__all__`

Check failure on line 503 in pyccel/ast/cwrapper.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

pyccel/ast/cwrapper.py#L503

`cwrapper.PyClassDef` is missing from `__all__`

Check warning on line 2 in tests/ndarrays/conftest.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/ndarrays/conftest.py#L2

Unexpected pylint disables: arguments-differ, inconsistent-return-statements, protected-access, abstract-method

Check warning on line 1 in tests/macro/scripts/blas/runtest_dger.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dger.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_dgemv.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dgemv.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_dgemm.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dgemm.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_dscal.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dscal.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_dswap.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dswap.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_dcopy.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_dcopy.py#L1

Unexpected pylint disables: undefined-variable, unused-import

Check warning on line 1 in tests/macro/scripts/blas/runtest_daxpy.py

See this annotation in the file changed.

@pyccel-bot pyccel-bot / Pyccel best practices (pyccel_lint, 3.8)

tests/macro/scripts/blas/runtest_daxpy.py#L1

Unexpected pylint disables: undefined-variable, unused-import