Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.10 with new Intel compiler #1673

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

yguclu
Copy link
Member

@yguclu yguclu commented Jan 11, 2024

When running tests with the Intel compiler on Linux in the devel branch, use Python 3.10 to avoid the workflow to hang.

With Python 3.9 the workflow was hanging as shown here: https://github.com/pyccel/pyccel/actions/runs/7494351871.

See PR #1672, where the same modification was applied to the run intel bot command.

Fix a minor bug with the pylint test by handling the case where there are no Python files modified in a PR.

@pyccel-bot
Copy link

pyccel-bot bot commented Jan 11, 2024

Hello! Welcome to Pyccel! Thank you very much for your contribution ❤️.

I am the GitHub bot. I will help guide you through the different stages necessary to validate a review in Pyccel. If you haven't yet seen our developer docs make sure you check them out here. Amongst other things they describe the review process that we have just started. You can also get in touch with our other developers on our Pyccel Discord Server.

To begin with I will give you a short checklist to make sure your pull request is complete. Please tick items off when you have completed them or determined that they are not necessary for this pull request. If you want me to run any specific tests to check out corner cases that you can't easily check on your computer, you can request this using the command /bot run X. Use the command /bot show tests to see a full list of the tests I can run. Once you have finished preparing your pull request and are ready to request reviews just take your PR out of draft, or let me know with the command /bot mark as ready. I will then run the full suite of tests to check that everything is as neat as you think before asking other contributors for reviews. Tests will not run automatically before this point to avoid wasting resources. You can get a full list of commands that I understand using /bot commands.

Please begin by requesting your checklist using the command /bot checklist

@github-actions github-actions bot marked this pull request as draft January 11, 2024 21:49
@yguclu
Copy link
Member Author

yguclu commented Jan 11, 2024

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing
  • Update AUTHORS file

@EmilyBourne
Copy link
Member

/bot run intel

@yguclu yguclu marked this pull request as ready for review January 12, 2024 09:10
@pyccel-bot
Copy link

pyccel-bot bot commented Jan 12, 2024

It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with /bot mark as ready.

@github-actions github-actions bot marked this pull request as draft January 12, 2024 09:10
@yguclu yguclu marked this pull request as ready for review January 12, 2024 09:11
@github-actions github-actions bot marked this pull request as draft January 12, 2024 09:12
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@EmilyBourne EmilyBourne marked this pull request as ready for review January 12, 2024 09:52
@pyccel-bot pyccel-bot bot added the Ready_to_merge Approved by senior developer. Ready for final approval and merge label Jan 12, 2024
@yguclu
Copy link
Member Author

yguclu commented Jan 12, 2024

@EmilyBourne Can you please update the PR description with your changes?

@EmilyBourne
Copy link
Member

Done

@yguclu yguclu merged commit 2301714 into devel Jan 12, 2024
11 checks passed
@yguclu yguclu deleted the intel-with-python-3.10 branch January 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants