List support/insert method #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to raise proper error message in case or dtype conflicts
|
/bot run docs pylint pyccel_lint spelling |
|
/bot run linux macosx windows |
|
/bot run coverage |
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
pyccel-bot
bot
added
the
Ready_for_review
|
@EmilyBourne, @Farouk-Echaref has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now? |
EmilyBourne
reviewed
Feb 19, 2024
EmilyBourne
reviewed
Feb 19, 2024
pyccel-bot
bot
added
Ready_to_merge
yguclu
requested changes
Feb 21, 2024
tests/errors/semantic/blocking/INSERT_LIST_INCOMPATIBLE_TYPES_2.py
Outdated
Show resolved
Hide resolved
tests/errors/semantic/blocking/INSERT_LIST_INCOMPATIBLE_TYPES_0.py
Outdated
Show resolved
Hide resolved
|
@Farouk-Echaref, @yguclu has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with |
pyccel-bot
bot
removed
the
Ready_to_merge
yguclu
approved these changes
Feb 21, 2024
pyccel-bot
bot
added
the
Ready_to_merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the insert() method of Python lists to the semantic stage.
Add handling of that method to the Python printer. This fixes #1692.
Commit Summary
insert()method, inheriting fromPyccelInternalFunction. The constructor ensures compatibility between the datatypes of theinsert()argument and the list for homogenous lists._class_typeattribute for methods that returnNone_print_ListInsert()to generate the appropriate Python representation of theinsert()method.insert()method involving many scenarios where the function could be used.