Domain coordinates should be real #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campospinto
approved these changes
Jun 17, 2024
campospinto
added a commit
that referenced
this pull request
Jul 24, 2024
The PR #156 defined domain coordinates with real=True argument. This is probably justified but requires additional testing as it breaks some calls to TerminalExpr. Here this change is reverted, and a dedicated PR will be reopened later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the domain coordinates are Sympy symbols but we don't specify them to be real.
Consequently when we take the real part of a complex expression of the coordinates, the resulting symbolic expression includes the imaginary part of the coordinate and eventually Pyccel throws an error.
Besides, setting the symbols to real simplifies considerably the expressions.