pycollada fixes from 1.5 branch, but in master #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged the effect properties load to be a function, and added function to also get effect properties from underneath the technique tag
…ing_ results in strings taken from name sources being incompatible with the same ids taken directly from node tags since python doesnt allow comparison of byte strings and unicode strings
jterrace
added a commit
that referenced
this pull request
Mar 5, 2015
pycollada fixes from 1.5 branch, but in master
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same as the pull request I made to the 1.5 branch, except in master per Jeff's recommendation to work out of master instead of the 1.5 branch. I'll do all fixes in master going forward