Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style.py: Drop unused CSS class .bold #161

Merged
merged 1 commit into from
Jul 7, 2022
Merged

style.py: Drop unused CSS class .bold #161

merged 1 commit into from
Jul 7, 2022

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Feb 2, 2022

No description provided.

@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label Feb 2, 2022
@hartwork hartwork force-pushed the drop-unused-bold branch 3 times, most recently from 40a1f8e to 9c0e74c Compare February 2, 2022 23:23
@hartwork
Copy link
Collaborator Author

@ssbarnea do you have a minute for review?

ssbarnea
ssbarnea approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some mixed feelings about that as I know that many terminals still support bold instead of bright.

Wait for extra reviews on this change.

@hartwork
Copy link
Collaborator Author

hartwork commented Feb 16, 2022 •
edited
Loading

I have some mixed feelings about that as I know that many terminals still support bold instead of bright.

Wait for extra reviews on this change.

@ssbarnea the class is unused altogether. No? There is no semantic effect expected.

@hartwork hartwork added this to the 1.7.1 milestone May 8, 2022
@ssbarnea
Copy link
Member

ssbarnea commented May 9, 2022

@hartwork Can you please rebase?

@hartwork
Copy link
Collaborator Author

@hartwork Can you please rebase?

@ssbarnea done

@ssbarnea ssbarnea merged commit 62d113b into pycontribs:main Jul 7, 2022
@hartwork hartwork deleted the drop-unused-bold branch January 2, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hartwork @ssbarnea