Setting Content-Encoding on Cloudfiles upload #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(readme): Add a link to the pyrax docs at docs.rackspace.com.
…cifying networks when creating a server
Cloud networks docs reference wrong kwarg for cs.servers.create
…) for other obj types
Bring pyrax.utils._wait_until operations for cloud servers in alignment with other objects
…n code. Added the utils.update_exc() method that allows additional text to be added to an exception before it is re-raised. Also added some code to catch the case where keyring_auth() is called with a username for which there is no stored password. Previously this would fail silently.
Previously if the call exceeded the number of attempts specified, it returned None. The default for the 'attempts' parameter has also been changed to 0, meaning that by default wait_until() will loop infinitely until the desired value of the att is reached.
…n the call to authenticate(). GitHub issue pycontribs#57
…nStack deployments, and not just Rackspace's. Still needs extensive testing on non-Rackspace auth systems.
Addressing CloudFiles client get_temp_url returning wrong url issue pycontribs#60
|
pyrax utilizes python-swiftclient instead of python-cloudfiles (deprecated), however the client.put_object() method of swiftclient, does support a headers argument, so I imagine, it could be as simple as updating client.upload_file and client.store_object of pyrax.cf_wrapper to take an additional headers argument. |
Added to both the client and container versions of these functions. This is primarily to add support for setting Content-Encoding: gzip to uploaded files. See http://docs.rackspace.com/files/api/v1/cf-devguide/content/Enabling_File_Compression_with_the_Content-Encoding_Header-d1e2198.html
|
Oops, accidentally pushed to pull from master instead of working. |
|
Unfortunately had to open a new pull request to get the branch right: #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't appear to be any way to set
Content-Encoding: gzipon uploaded files. In python-cloudfiles you can manually set headers on the storage object you get by callingcontainer.create_object()before you callsend()on it.See http://docs.rackspace.com/files/api/v1/cf-devguide/content/Enabling_File_Compression_with_the_Content-Encoding_Header-d1e2198.html