Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add headers argument to upload_file and store_object #66

Closed
wants to merge 1 commit into from

Conversation

joeshaw
Copy link
Contributor

@joeshaw joeshaw commented May 7, 2013

Added to both the client and container versions of these functions. This is
primarily to add support for setting Content-Encoding: gzip to uploaded files.

See
http://docs.rackspace.com/files/api/v1/cf-devguide/content/Enabling_File_Compression_with_the_Content-Encoding_Header-d1e2198.html

Added to both the client and container versions of these functions.
This is primarily to add support for setting Content-Encoding: gzip
to uploaded files.

See http://docs.rackspace.com/files/api/v1/cf-devguide/content/Enabling_File_Compression_with_the_Content-Encoding_Header-d1e2198.html
@EdLeafe
Copy link
Contributor

EdLeafe commented May 7, 2013

This is a good addition, but I'd like to see it consistent with the rest of the parameters. 'Content-type' is passed as the named parameter content_type; it would be better to add a content_encoding parameter as well to the method signatures, and then convert to the headers argument when calling swiftclient.

The goal of an SDK is to smooth out the warts of the underlying APIs, making development more consistent. The fact that swiftclient accepts named params for some things and not others is a wart IMO.

@EdLeafe EdLeafe closed this May 7, 2013
@joeshaw
Copy link
Contributor Author

joeshaw commented May 7, 2013

Force pushed an updated commit to my branch (d2d812b).

@joeshaw
Copy link
Contributor Author

joeshaw commented May 7, 2013

Opened #67 with an updated patch, since this one was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants