Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect ordering is passing for reasons I don't understand #9

Closed
alex opened this issue Jun 18, 2014 · 1 comment
Closed

Incorrect ordering is passing for reasons I don't understand #9

alex opened this issue Jun 18, 2014 · 1 comment

Comments

@alex
Copy link
Contributor

alex commented Jun 18, 2014

As far as I know, this should fail because the imported names aren't sorted alphabetically, but for me it doesn't show any warnings

from sqlalchemy import Integer, MetaData, Column

Integer, MetaData, Column,
@alex
Copy link
Contributor Author

alex commented Jun 18, 2014

The answer is that the first import is not properly checked because it's skipped here: https://github.com/public/flake8-import-order/blob/master/flake8_import_order/__init__.py#L173

@public public closed this as completed in 98fae15 Jun 19, 2014
public added a commit that referenced this issue Jun 19, 2014
@public
Merge pull request #11 from alex/bad-first-import
4b0d83a 
Properly process the first import in a group. Fixes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex