Replace module level factory functions with type constructors #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds assertions that the memory is in fact zeroed. In the future the assertions should only be checked in debug mode.
This code seems to be necessary on Python 3. On Python 2, serialization was already not working.
p
added a commit
that referenced
this pull request
Jun 25, 2014
Replace module level factory functions with type constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, although "Curl" was advertised as a type,
pycurl.Curlet al were really global factory functions that returned instances of the Curl type. The biggest issue this caused was inability to properly document pycurl objects.pycurl.Curl.setopt, for example, did not exist, as Curl was not a type.This PR transforms the old factory functions into constructors in
tp_newslots. This makes it possible to expose actual types aspycurl.Curland such, making documentation work properly.