Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #11

Open
pydanny opened this issue Sep 24, 2023 · 0 comments
Open

Improve test coverage #11

pydanny opened this issue Sep 24, 2023 · 0 comments
Labels
hactoberfest Signal for hacktoberfest tickets

Comments

@pydanny
Copy link
Owner

pydanny commented Sep 24, 2023 •
edited

Our current test coverage on September 30th is 52%:

Name                            Stmts   Miss  Cover   Missing
-------------------------------------------------------------
src/dj_notebook/__init__.py        13      3    77%   28-30
src/dj_notebook/shell_plus.py      44     26    41%   24-38, 43-51, 55, 60-67, 80-85, 89-91
tests/__init__.py                   0      0   100%
tests/test_dj_notebook.py           4      0   100%
-------------------------------------------------------------
TOTAL                              61     29    52%

Any improvement that increases the total percentage by at least 1% qualifies for hacktoberfest.
@pydanny pydanny changed the title Add meaningful tests Improve test coverage Sep 30, 2023
@pydanny pydanny added the hactoberfest Signal for hacktoberfest tickets label Sep 30, 2023
pydanny added a commit that referenced this issue Oct 2, 2023
@pydanny
Merge pull request #39 from skyforest/improve-test-coverage
4b02cf1 
This is part of #11.

* Testing if namify converts class name and module into desired format

* defining test for draw_connections

* classes to test relationships

* assertions showing if relationships are true within graph connections (includes leading spaces which was throwing me off)

* reverting .gitignore to original

* running lint

* formatting to make ruff happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hactoberfest Signal for hacktoberfest tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pydanny