Remove special case for test harness from application code. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses pydanny#88, at least partially. This adds a context manager that ensures django settings are reset on exit, and has the two unit tests that call `activate()` use it. It also adds two minimal settings modules that match the config those tests were seeing, and passes the names of those modules to `activate()` so that those are loaded using the same path as user-supplied settings modules. I thought about using pytest-django's settings fixture, but the way `activate()` and `Plus` interact made that smell more than the original hack.
…able got created before attempting to delete it. Tests that threw before setting the variable would terminate with a KeyError in the context manager instead of seeing their exceptions reported appropriately.
pydanny
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #88, at least partially.
This adds a context manager that ensures django settings are reset on exit, and has the two unit tests that call
activate()use it.It also adds two minimal settings modules that match the config those tests were seeing, and passes the names of those modules to
activate()so that those are loaded using the same path as user-supplied settings modules.I thought about using pytest-django's settings fixture, but the way
activate()andPlusinteract made that smell more than the original hack.