Allow notebooks in other locations #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmpowell
force-pushed
the
allow-notebooks-in-other-locations
branch
2 times, most recently
from
9b134df
to
2eb64be
Compare
nmpowell
force-pushed
the
allow-notebooks-in-other-locations
branch
from
2eb64be
to
d9cdafe
Compare
|
Hey @nmpowell! I just saw this PR, sorry I didn't look at it earlier. I'll review it first thing tomorrow when I'm fresh and ready to take a good look. 😄 |
pydanny
approved these changes
Mar 2, 2024
|
PyPI release done: https://pypi.org/project/dj-notebook/0.7.0/ You're now in the list of contributors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
dj-notebookassumes your Jupyter Notebooks are stored in the same directory as your Django project.This PR allows you to store your Notebooks in a separate directory, for example if you don't want to add them to source control, or you organise your notebooks separately.
It adds a
search_dirparam toactivate(as in,plus.activate(search_dir=...)), enabling the following usage:This piggybacks on the existing function
find_django_settings_modulesearching parents and immediate children of the supplied directory. Thus if yourmanage.pyis in the abovesrcdirectory, you can also usesearch_dir=/home/username/your-django-project"orsearch_dir=/home/username/your-django-project/src/subdir". If nosearch_diris supplied, it retains the existing functionality of usingPath.cwd().A couple of minor tweaks also included in separate commits.