Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video component #71

Merged
merged 4 commits into from
Dec 17, 2023
Merged

Add video component #71

merged 4 commits into from
Dec 17, 2023

Conversation

ischaojie
Copy link
Contributor

@ischaojie ischaojie commented Dec 5, 2023

fixes #54

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #71 (e40da5c) into main (c9e8bb9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          118       118           
=========================================
  Hits           118       118           

Copy link

codecov bot commented Dec 7, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks so much.

please rebase, resolve conflicts and make sure tests are passing - I suspect you'll need to do a bit of work to make sure the JSON Schemas match.

You also need to add video to the list of components in the demo index page.

By the way, please can you use fixes #54 in the PR body so the issue is automatically closed when the PR is merged, otherwise I'll forget. see here.

demo/components_list.py Outdated Show resolved Hide resolved
@ischaojie ischaojie marked this pull request as ready for review December 13, 2023 10:08
@ischaojie
Copy link
Contributor Author

What's your opinion of the comments here #54 (comment) ?

@samuelcolvin
Copy link
Member

I think this looks great as a start, let's merge this once fixed and see what people think.

1 similar comment
@samuelcolvin
Copy link
Member

I think this looks great as a start, let's merge this once fixed and see what people think.

@samuelcolvin samuelcolvin merged commit e7e3600 into pydantic:main Dec 17, 2023
16 checks passed
@samuelcolvin
Copy link
Member

thanks so much.

@ischaojie ischaojie deleted the dev branch December 18, 2023 01:52
@samuelcolvin samuelcolvin mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio and Video components.
4 participants