Update dependencies, especially OTEL #337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| 'opentelemetry.instrumentation.starlette', | ||
| 'opentelemetry.instrumentation.fastapi', |
There was a problem hiding this comment.
| ) -> Meter: | ||
| with self.lock: | ||
| meter = _ProxyMeter( | ||
| self.provider.get_meter(name, version=version, schema_url=schema_url), | ||
| self.provider.get_meter(name, version=version, schema_url=schema_url, *args, **kwargs), |
There was a problem hiding this comment.
| instrumenting_library_version=instrumenting_library_version, | ||
| schema_url=schema_url, | ||
| ) | ||
| return self.provider.get_tracer(*args, **kwargs) |
There was a problem hiding this comment.
| @@ -146,7 +146,7 @@ def test_create_metric_gauge(metrics_reader: InMemoryMetricReader) -> None: | |||
| 'data_points': [ | |||
| { | |||
| 'attributes': {}, | |||
| 'start_time_unix_nano': 0, | |||
| 'start_time_unix_nano': None, | |||
There was a problem hiding this comment.
|
We still support the older versions with this PR, right? |
|
I haven't explicitly tested, but the logic should be more compatible with both past and future versions. |
|
@alexmojaki do you have a proposal on how to test multiple versions of packages? I know we have an issue about it... But is the intention to run those only on the CI? |
|
OTEL instrumentations sometimes have multiple requirements files for tests, e.g. in https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-django They have a tox setup to use these files. I haven't managed to get it working myself and it looks very complicated. But maybe we could do something similar. If we eventually start putting lots of effort into supporting multiple versions then I think it will be very helpful to be able to simultaneously test them locally. But it's probably easier to start with just testing in CI. We can add local helpers once the workflow becomes painful. |
Handles new releases: