Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Validator::complete required #496

Closed
dmontagu opened this issue Mar 29, 2023 · 2 comments
Closed

Make Validator::complete required #496

dmontagu opened this issue Mar 29, 2023 · 2 comments

Comments

@dmontagu
Copy link
Collaborator

Removing the need for complete() is hard, it might even be impossible, definitely not with the hassle now.

Making complete required is very simple and probably worthwhile, feel free to do it here or create an issue.

Originally posted by @samuelcolvin in #494 (review)

The reason to do this is that it's easy to add a new validator type in pydantic core and forget that you need to implement this method if it references other validators (otherwise your DefinitionRefValidator-produced loc's will be wrong)

@aminalaee
Copy link
Contributor

Since #525 is merged, this can be closed.

@samuelcolvin
Copy link
Member

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants