Fix Validator::complete not being implemented properly for all validator types #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Mar 29, 2023
| @@ -166,7 +166,7 @@ def type_dict_schema(typed_dict) -> dict[str, Any]: # noqa: C901 | |||
| return {'type': 'typed-dict', 'fields': fields, 'extra_behavior': 'forbid'} | |||
|
|
|||
|
|
|||
| def union_schema(union_type: UnionType) -> core_schema.UnionSchema | core_schema.RecursiveReferenceSchema: | |||
| def union_schema(union_type: UnionType) -> core_schema.UnionSchema | core_schema.DefinitionReferenceSchema: | |||
There was a problem hiding this comment.
I noticed a few out-of-date references to RecursiveReferenceSchema and fixed those up as well.
|
please review |
CodSpeed Performance ReportMerging #494 Summary
|
|
I will merge this as is now, but created an issue: #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue of some definitions refs not getting updated properly.
The issue in pydantic only required the fix for ModelValidator, but the comments where this stuff is used seemed to indicate that every contained validator should have
completecalled. So I went through all the files and made sure this was done (many were missing this).I think it might be preferable if you had to explicitly define the
fn completefor each Validator type and didn't get a default for free, but I don't know how hard that would be to refactor. (Yes there would be a bunch of trivial implementations but I feel that's less likely to cause errors than forgetting to "complete" a new validator type.)Alternatively I guess it could make sense to refactor so this "completion" wasn't necessary, if that's even possible, but I also don't know how hard that would be.