Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds a new set of
test_north_star
benchmarks which we can potentially use to get a general sense of performance for something which (I hope) looks like a typical use-case.The commit contains a new file
generate_data.py
which creates a ~500KB file to be used as input for the benchmarks. I didn't check this file in yet, although I am happy to (or consider alternative strategies like storing in S3).The north star benchmarks measure time for successful validation for each of json and python inputs, in both lax and strict mode. There is also a comparison to
json.dumps
to measure our overhead. On my machine, this is current measurements:Here are the v1 measurements by comparison:
Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)