🐛 Fix handling of bool literals

[lig]

Change Summary

Treat bool literals (Literal[False], Literal[True]) as generic py objects instead of ints.

Related issue number

See pydantic/pydantic#6601

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

[codecov]

Codecov Report

Merging #783 (eeba6bd) into main (9be711e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   93.67%   93.70%   +0.03%     
==========================================
  Files          99       99              
  Lines       14290    14292       +2     
  Branches       25       25              
==========================================
+ Hits        13386    13393       +7     
+ Misses        898      893       -5     
  Partials        6        6              

Impacted Files	Coverage Δ
src/serializers/type_serializers/literal.rs	75.53% <100.00%> (+5.96%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be711e...eeba6bd. Read the comment docs.

[codspeed-hq]

CodSpeed Performance Report

Merging #783 will improve performances by 11.7%

_{Comparing lig/6601 (eeba6bd) with main (e3ceb4b)}

Summary

🔥 1 improvements
✅ 125 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	lig/6601	Change
🔥	test_small_class_core_model	50.8 µs	45.5 µs	+11.7%

[lig]

please review

[adriangb]

Good call, but can we special case them as well actually? I'd think it's a pretty reasonable thing to use as a discriminant so fast pathing it makes sense. I don't think we need any sort of lookup, maybe just an enum with two variants being CombinedSerializers.

[lig]

I don't see why special casing bools here will be beneficial enough. There is no evidence that this is a common case and there is no special treatment necessary to make it work.

[adriangb]

If you asked me what I would do I would special case nothing. But we're already special casing primitive types so let's do the same for bools.

[adriangb]

Apologies, after reviewing the code I see that this is about serialization, not validation. Let me check what happens during validation.

[adriangb]

Validation works well:

from typing import Literal, Union
from pydantic import BaseModel


class Model(BaseModel):
    x: Literal[0, False]
    y: Union[str, Literal[False]]
    z: Union[Literal[False], str]
    xx: Union[int, Literal[False]]
    yy: Union[Literal[False], int]


print(Model(x=False, y=False, z=False, xx=False, yy=False))
#> x=False y=False z=False xx=False yy=False

[adriangb]

LGMT my earlier feedback was misguided

[lig]

thanks!