Remove xfail for discriminated union with alias (#6938)

pydantic · Jul 29, 2023 · 66038be · 66038be
1 parent bb43605
commit 66038be
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/tests/test_json_schema.py b/tests/test_json_schema.py
@@ -3893,7 +3893,6 @@ class Model(BaseModel):
     }
 
 
-@pytest.mark.xfail(reason='json schema generation for tagged unions is fundamentally incompatible with references')
 def test_alias_same():
     class Cat(BaseModel):
         pet_type: Literal['cat'] = Field(alias='typeOfPet')
@@ -3934,7 +3933,7 @@ class Model(BaseModel):
             'pet': {
                 'oneOf': [{'$ref': '#/$defs/Cat'}, {'$ref': '#/$defs/Dog'}],
                 'title': 'Pet',
-                'discriminator': 'something',
+                'discriminator': {'mapping': {'cat': '#/$defs/Cat', 'dog': '#/$defs/Dog'}, 'propertyName': 'typeOfPet'},
             },
         },
         'required': ['pet', 'number'],