Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to all public methods/objects #372

Closed
samuelcolvin opened this issue Jan 24, 2019 · 1 comment · Fixed by #373
Closed

Add type hints to all public methods/objects #372

samuelcolvin opened this issue Jan 24, 2019 · 1 comment · Fixed by #373
Labels
feature request

Comments

@samuelcolvin
Copy link
Member

From python/mypy#6251 should fix #245, fix #366.

Need to remember to add @no_type_check to BaseModel.__getattr__.

If anyone would like to work on this, that would be great. Otherwise, I'll do it when I have time.
@samuelcolvin samuelcolvin mentioned this issue Jan 24, 2019
Closed
@samuelcolvin
Copy link
Member Author

ref #130

samuelcolvin added a commit that referenced this issue Jan 26, 2019
@samuelcolvin
add type hints, fix #372
c37e01c
@samuelcolvin samuelcolvin removed the help wanted Pull Request welcome label Jan 26, 2019
@samuelcolvin samuelcolvin mentioned this issue Jan 26, 2019
Merged
4 tasks
samuelcolvin added a commit that referenced this issue Feb 4, 2019
@samuelcolvin
add type hints (#373)
9ef4018 
* add type hints, fix #372

* fix tests and BaseModel inference

* fix #280

* fix dataclasses and docs

* more typing

* adding hints to fields.py

* type **EVERTHING*

* fix for 3.6

* small speed ups and some typ checks

* correct model.copy

* update history
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this issue Dec 23, 2023
@samuelcolvin
general to_json method and more inferred types (pydantic#372)
7d7ca9f 
* general "to_json" method and more inferred types

* support or filtering generators

* increase CI width

* allow windows tests to fail

* another xfail

* remove incorrect xfail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add type hints pydantic/pydantic
1 participant
@samuelcolvin