documentation: remove strict_optional from sample mypy.ini #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really not critical, but strict_optional=True is the default for mypy since 0.600, so its presence in the sample mypy.ini in the docs seems redundant. https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-strict-optional
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3895 3895
Branches 783 783
=========================================
Hits 3895 3895 Continue to review full report at Codecov.
|
brianmaissy
changed the title
|
thanks. |
inabayuta
added a commit
to inabayuta/pydantic
that referenced
this pull request
Oct 12, 2020
* commit '8ccc5708f120f65582cf9238592c6004efffc32d': (22 commits) remove data.json, fix pydantic#1992 (pydantic#1994) Include tests in source distributions (pydantic#1976) Fix const validator not running when class validators are present (pydantic#1957) Force fields.Undefined to be a singleton objectIn various places of the code, we compare directly to `fields.Undefined`since we assume it to be constant.When new models get created however, the object is deepcopied andis no longer identical with the original object.We therefore add `__copy__` and `__deepcopy__` methods to ensurethat the copied objects are actually the same original object. (pydantic#1981) test_config_file_settings_nornir: use less common env. var names (pydantic#1977) fix linting docs: fix typo (pydantic#1959) - fix typo in docs/index.md (pydantic#1921) Fix typo in docstring (pydantic#1866) add a __call__ stub to PyObject for mypy (pydantic#1849) remove strict_optional from sample mypy.ini in doc (pydantic#1830) docs: Fix incorrect description of copy method (pydantic#1821) feat(tools): add `parse_raw_as` util (pydantic#1813) Bump isort from 5.5.4 to 5.6.1 (pydantic#1980) feat(dotenv): support home directory relative paths (e.g. ~/.env) (pydantic#1804) combined uprev of dependencies (pydantic#1978) Bump pytest from 6.0.1 to 6.1.1 (pydantic#1965) clarify argument type to parse_file (pydantic#1795) Fix pydantic#1770 (pydantic#1771) fix(schema): add basic support of Pattern type in schema generation (pydantic#1768) ... # Conflicts: # docs/index.md # docs/mypy_plugin.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really trivial suggested change, but strict_optional=True is the default for mypy since 0.600, so its presence in the sample mypy.ini in the docs seems redundant.
https://mypy.readthedocs.io/en/stable/config_file.html#none-and-optional-handling