Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 13/19 digits VISA credit cards in PaymentCardNumber type #2286

Conversation

AlexanderSov
Copy link
Contributor

@AlexanderSov AlexanderSov commented Jan 24, 2021

Change Summary

Added support for 13/19 digits VISA credit cards in PaymentCardNumber type.

Related issue number

fix #1416

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #2286 (dcb3c5b) into master (13a5c7d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master    #2286      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files           21       23       +2     
  Lines         4199     4486     +287     
  Branches       854      906      +52     
===========================================
+ Hits          4199     4485     +286     
- Misses           0        1       +1     
Impacted Files Coverage Δ
pydantic/types.py 100.00% <100.00%> (ø)
pydantic/typing.py 99.41% <0.00%> (-0.59%) ⬇️
pydantic/fields.py 100.00% <0.00%> (ø)
pydantic/schema.py 100.00% <0.00%> (ø)
pydantic/networks.py 100.00% <0.00%> (ø)
pydantic/decorator.py 100.00% <0.00%> (ø)
pydantic/validators.py 100.00% <0.00%> (ø)
pydantic/dataclasses.py 100.00% <0.00%> (ø)
pydantic/env_settings.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a5c7d...dcb3c5b. Read the comment docs.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks great.

changes/1416-AlexanderSov.md Outdated Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
@AlexanderSov
Copy link
Contributor Author

@samuelcolvin Can we merge this PR?

@samuelcolvin samuelcolvin merged commit c8883e3 into pydantic:master Feb 23, 2021
@samuelcolvin
Copy link
Member

thanks so much. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for 13/19 digits VISA credit cards in PaymentCardNumber type
3 participants