-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(encoder): serialize NameEmail to str #2479
fix(encoder): serialize NameEmail to str #2479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2479 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5109 5110 +1
Branches 1050 1050
=========================================
+ Hits 5109 5110 +1
Continue to review full report at Codecov.
|
38b1ae5
to
86416de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to explain your change in changes/2341-alecgerona.md
e.g.
allow serialization of NameEmail
86416de
to
f3096a8
Compare
@PrettyWood weird my only change was that I added one line to the md file as you said but CI / test fastAPI suddenly didn't work. Is this just a case of retry or am I missing something? |
f3096a8
to
ab6f11c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This should be fixed upstream, see #2630. Can you re-run the test and then possibly merge? I'm eagerly awaiting this. ;) Edit: Never mind, fastAPI hasn't released 0.64.0 yet. It hasn't released anything this year, in fact. Does that mean that pydantic is stuck with this issue? |
👍 thanks so much. |
Thanks @samuelcolvin! Was trying to find the time to rerun the tests 😂. Glad you merged it still. |
Wonderful, thank you! |
Change Summary
Make NameEmail json serializable.
Related issue number
closes #2341
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)