Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "trying to fix fastapi tests (#2584)" #2630

Closed
wants to merge 1 commit into from

Conversation

PrettyWood
Copy link
Member

@PrettyWood PrettyWood commented Apr 5, 2021

This reverts commit 7b7e705.

The issue has been fixed upstream https://github.com/encode/databases/releases/tag/0.4.3

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@PrettyWood
Copy link
Member Author

Nevermind...databases pinned the version but in 0.4.3
fastapi still uses databases < 0.4.
And sqlalchemy has been pinned on master but there is not a new release since then. We need to wait for fastapi 0.64.0

@PrettyWood PrettyWood closed this Apr 5, 2021
@PrettyWood PrettyWood deleted the remove-fastapi-tweak branch April 5, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant