Renamed schema variable name to schema_ as there is a schema function defined #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Please could you add a change description. Also, in future please use the PR template. |
|
Done |
samuelcolvin
reviewed
May 1, 2021
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
PrettyWood
approved these changes
Sep 4, 2021
|
Thanks! 🙏 |
jpribyl
pushed a commit
to liquet-ai/pydantic
that referenced
this pull request
Oct 7, 2021
… defined (pydantic#2724) * Renamed schema variable name to schema_ as there is a schema function already defined * Same approach in enum_process_schema() * added changes file * Update changes/2724-shahriyarr.md Co-authored-by: Samuel Colvin <samcolvin@gmail.com> * last shadow rename Co-authored-by: Samuel Colvin <samcolvin@gmail.com> Co-authored-by: PrettyWood <em.jolibois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Spotted an anti-pattern which can lead to shadowing in the outer scope, as there is a function named
schema.Renamed all
schemavariables toschema_Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)