Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for email-validator version >= 2.0 #6033

Merged
merged 6 commits into from Nov 28, 2023
Merged

check for email-validator version >= 2.0 #6033

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0fe376
check for email-validator version >= 2.0
commonism May 15, 2023
90f49f8
email-validator - tested with …
commonism Nov 13, 2023
3e5fa51
Update pydantic/networks.py with more simple version check
sydney-runkle Nov 27, 2023
e0fdd4d
using importlib.metadata
commonism Nov 28, 2023
2f2e9a1
missing import
commonism Nov 28, 2023
826de5c
lint
commonism Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions pydantic/networks.py
View file
Open in desktop
Expand Up @@ -363,6 +363,13 @@ def import_email_validator() -> None:
import email_validator
except ImportError as e:
raise ImportError('email-validator is not installed, run `pip install pydantic[email]`') from e
if hasattr(email_validator, '__version__') and getattr(email_validator, '__version__', '').partition('.')[0] == '2':
sydney-runkle marked this conversation as resolved.
Show resolved Hide resolved
return
else:
input_email = 'testaddr@example.tld'
valid_email = email_validator.validate_email(input_email, check_deliverability=False)
if not hasattr(valid_email, 'normalized'):
raise ImportError('email-validator version >= 2.0 required')


if TYPE_CHECKING:
Expand Down