Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cython build #7696

Closed
wants to merge 3 commits into from
Closed

Fix Cython build #7696

wants to merge 3 commits into from

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Sep 28, 2023

fixes #7689

Selected Reviewer: @samuelcolvin

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82fe532
Status: ✅  Deploy successful!
Preview URL: https://42e67f34.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-cython-build.pydantic-docs2.pages.dev

View logs

@@ -268,7 +268,7 @@ jobs:
- name: set up python
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: '3.11'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this because of failure on Python 3.10

@hramezani
Copy link
Member Author

Please review

@samuelcolvin
Copy link
Member

closing as no updates on this. Happy to reconsider if we get more reports and more details.

@samuelcolvin samuelcolvin deleted the fix-cython-build branch October 27, 2023 14:05
@cp2004
Copy link

cp2004 commented Oct 30, 2023

PiWheels removed the broken wheel builds, and home assistant patched their wheel builds (home-assistant/core#101976) so the original reporters 'effectively stopped' running into this issue would be my understanding. I would think the root of the issue still needs to be fixed however?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants