Increase test coverage a bit #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
davidhewitt
reviewed
Nov 6, 2023
| @@ -130,7 +129,7 @@ def for_model(cls, bases: tuple[type[Any], ...], namespace: dict[str, Any], kwar | |||
| return cls(config_new) | |||
|
|
|||
| # we don't show `__getattr__` to type checkers so missing attributes cause errors | |||
| if not TYPE_CHECKING: | |||
| if not TYPE_CHECKING: # pragma: no branch | |||
There was a problem hiding this comment.
What's the justification for the pragma here?
There was a problem hiding this comment.
coverage says this line is partially covered because the condition is never false. no branch (not no cover) says to ignore that, because not TYPE_CHECKING will never be false at runtime.
| @@ -196,7 +196,7 @@ def wrapped_model_post_init(self: BaseModel, __context: Any) -> None: | |||
| # this is the BaseModel class itself being created, no logic required | |||
| return super().__new__(mcs, cls_name, bases, namespace, **kwargs) | |||
|
|
|||
| if not typing.TYPE_CHECKING: | |||
| if not typing.TYPE_CHECKING: # pragma: no branch | |||
davidhewitt
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
A few small tweaks and additions to tests to increase overall test coverage.
Related issue number
Part of #7656
Checklist
Selected Reviewer: @davidhewitt