-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various minor issues in docstrings #8372
Conversation
Deploying with
|
Latest commit: |
c5e4e86
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b4032533.pydantic-docs2.pages.dev |
Branch Preview URL: | https://dmontagu-minor-docs-fixes.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #8372 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a few questions and one or two suggestions 👍.
Thanks for doing this!
@@ -679,20 +681,20 @@ def Field( # noqa: C901 | |||
multiple_of: Value must be a multiple of this. Only applicable to numbers. | |||
min_length: Minimum length for strings. | |||
max_length: Maximum length for strings. | |||
pattern: Pattern for strings. | |||
pattern: Pattern for strings (a regular expression). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say anything here about configuring the regex_engine
? Fine if not, bc I believe that's at the model_config
level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
No description provided.