Avoid erroring when OMP_NUM_THREADS is empty string #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FrancescAlted gentle ping thoughts here? |
bashtage
reviewed
Feb 8, 2024
numexpr/utils.py
Outdated
| @@ -152,7 +152,8 @@ def _init_num_threads(): | |||
| # actual number of threads used. | |||
| if 'NUMEXPR_NUM_THREADS' in os.environ: | |||
There was a problem hiding this comment.
Would be good to fix this one as well, and any others that blindly call int on an environmental variable. Would it be more pythonic to try/except and then reraise (or warn) with an explanation?
There was a problem hiding this comment.
I think an empty string should be fine, so just ignoring it seems good to me
FrancescAlted
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
This sounds good to me. When we are that, would you like to add the suggestion by @bashtage ?
|
Updated |
|
Unfortunately test suite is not passing with the latest commit. |
|
should be fixed now |
|
Looks good. Thanks @phofl ! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsetting the variable like this is not uncommon but this will raise here unfortunately
This circumvents the issue