Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas data reader for google end dates are not working #395

Closed
nithints opened this issue Sep 16, 2017 · 7 comments
Closed

Pandas data reader for google end dates are not working #395

nithints opened this issue Sep 16, 2017 · 7 comments

Comments

@nithints
Copy link

import pandas_datareader.data as web
import datetime
start = datetime.datetime(2010, 1, 1)

end = datetime.datetime(2015, 5, 9)

web.DataReader('AAPL', 'google', start, end)

getting an year data irrespective of start and end dates
image

@rsvp
Copy link

rsvp commented Sep 16, 2017

@bkcollection
Copy link

@rsvp Is the google historical data is just merely a change of link from www.google.com to finance.google.com ?
or it has a more complicated issues to deal with before merge into pandas-datareader? If it is stopped will cause a big issues for non US user as we do not have any alternatives which is need to cost a lot of money like Bloomberg/reuters

@rsvp
Copy link

rsvp commented Sep 23, 2017

@bkcollection I have covered both Google Finance URL Change and Alternative Data Sources at rsvp/fecon235#7 in detail. The situation is still in flux.

@1rocketdude
Copy link

1rocketdude commented Sep 24, 2017 via email

@innocentkithinji
Copy link

It is easy to fix just change the googles daily.py file to look llike this one.
The reason it doesnt fetch the data is that google changed its finance url from http://www.google.com/finance/historical to http://finance.google.com/finance/historical during the redirect the dates are not passed in the HTTP request.

@EngJay
Copy link

EngJay commented Nov 12, 2017

I just ran into this issue with version 0.5.0 and confirmed that the fix suggested above by @innocentkithinji does restore expected functionality.

@davidastephens
Copy link
Member

Fixed in #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants