Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various failures in tests #404

Merged
merged 5 commits into from Oct 8, 2017

Conversation

@davidastephens
Copy link
Member

davidastephens commented Oct 1, 2017

No description provided.

David Stephens added 3 commits Oct 1, 2017
See: http://mba.tuck.dartmouth.edu/pages/faculty/ken.french/Data_Library/changes_crsp.html

Please note: CRSP has recently completed the Pre62 Daily Data Series Project. The addition of these new daily data results in changes to month-end prices and to dividend ex-dates. These changes have resulted in many small changes to historical returns on my website.
David Stephens
David Stephens
Add note to docs re: status of google quotes

rebase
David Stephens added 2 commits Oct 1, 2017
Uses non-weekend date for test, using a weekend date is ambiguous

squash
David Stephens
@davidastephens

This comment has been minimized.

Copy link
Member Author

davidastephens commented Oct 1, 2017

resolves: #403
resolves: #402
fixes: #394
fixes: #395

@davidastephens davidastephens merged commit edc8a8d into master Oct 8, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-1.0%) to 86.386%
Details
@rsvp

This comment has been minimized.

Copy link

rsvp commented Oct 8, 2017

@davidastephens For the Google Finance test fix, the use of pytest.skip
seems too definitive in the sense that Google may reconsider its API changes
during the reconstruction period. So how about using pytest.xfail or even more
explicitly @pytest.mark.xfail() with condition and reason attached?
See https://docs.pytest.org/en/latest/skipping.html

That way we can later run: pytest --runxfail
to see if Google has reverted without much hassle,
and just remove the decorators.
(Historically, Google has reversed its pronouncements on quote
retrieval via Sheets, so there's hope if there's enough public outcry :-).

@rsvp

This comment has been minimized.

Copy link

rsvp commented Dec 10, 2017

hi @davidastephens -- could you kindly summarize what was fixed?

Many disparate issues were closed, so it might be useful to
review the root problems which were solved.

In what pandas_datareader version will the fixes be distributed? Thanks!

@davidastephens

This comment has been minimized.

Copy link
Member Author

davidastephens commented Dec 11, 2017

Hi @rsvp: Each commit has detail as to what was fixed. I aggregated into one pull request so I could get the travis tests to pass.

These fixes will be distributed in 0.6.0, but unfortunately, a significant portion of this package no longer works due to API removals. I've noted which apis no longer work in the docs and skipped the tests, but unsure if we should do anything in the code. Would adding DeprecationWarnings be helpful?

@rsvp

This comment has been minimized.

Copy link

rsvp commented Dec 11, 2017

@davidastephens: hi, I think DeprecationWarnings would be most helpful
since users would understand their own working code is not at fault,
but rather API changes from the data vendors. The warnings should
point to a summary page where the problems and limitations have
been detailed, and possible remedies discussed.

My best summary is here: rsvp/fecon235#7
but when pandas_datareader 0.6.0 ships :shipit: I can write up a
clean wiki page. I suggest pddr404api as the hashtag keyword
since that currently has no document matches via a Google search.

@matheuscouto

This comment has been minimized.

Copy link

matheuscouto commented on 7d8803d Dec 22, 2017

Thanks

This comment has been minimized.

Copy link

MaricheloGv replied Feb 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.