Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_data_yahoo() Bug in windows when start date is earlier than 1970-1-1 8:00 #846

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ice-tong
Copy link

@ice-tong ice-tong commented Feb 10, 2021

Fix get_data_yahoo() Bug in windows when satrt date is earlier than 1970-1-1 8:00

Bug reproduce:

from pandas_datareader import data as web
web.get_data_yahoo("IBM", start='1968-02-28', end='2020-02-08', interval="d")

ERROR Overflow error: mktime argument out of range

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check pandas_datareader
  • added entry to docs/source/whatsnew/vLATEST.txt

… 1970-1-1 8:00

Bug reproduce: 
``` python3
from pandas_datareader import data as web
web.get_data_yahoo("IBM", start='1968-02-28', end='2020-02-08', interval="d")
```
ERROR `Overflow error: mktime argument out of range`
… occurrence of `OverflowError: mktime argument out of range`.
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #846 (d22667c) into master (90f155a) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   64.36%   63.79%   -0.57%     
==========================================
  Files          62       62              
  Lines        2848     2848              
  Branches      305      305              
==========================================
- Hits         1833     1817      -16     
- Misses        939      957      +18     
+ Partials       76       74       -2     
Impacted Files Coverage Δ
pandas_datareader/tests/test_eurostat.py 61.90% <0.00%> (-21.43%) ⬇️
pandas_datareader/io/util.py 66.66% <0.00%> (-11.12%) ⬇️
pandas_datareader/compat/__init__.py 78.78% <0.00%> (-3.04%) ⬇️
pandas_datareader/io/sdmx.py 88.57% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f155a...d22667c. Read the comment docs.

@ice-tong ice-tong changed the title Fix get_data_yahoo() Bug in windows when satrt date is earlier than 1970-1-1 8:00 Fix get_data_yahoo() Bug in windows when start date is earlier than 1970-1-1 8:00 May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants