CLN: Removed the return_type param in StringMethods.split #13701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
series-return-type-remove
branch
from
99202eb
to
375ed6a
Compare
| @@ -541,6 +541,7 @@ Removal of prior version deprecations/changes | |||
| - ``DataFrame.to_dict()`` has dropped the ``outtype`` parameter in favor of ``orient`` (:issue:`13627`, :issue:`8486`) | |||
| - ``pd.Categorical`` has dropped setting of the ``ordered`` attribute directly in favor of the ``set_ordered`` method (:issue:`13671`) | |||
| - ``pd.Categorical`` has dropped the ``levels`` attribute in favour of ``categories`` (:issue:`8376`) | |||
| - ``pd.core.strings.StringMethods.split`` has dropped the ``return_type`` parameter in favor of ``expand`` (:issue:`13701`) | |||
There was a problem hiding this comment.
Other release notes simply write .str.split.
There was a problem hiding this comment.
Sure thing. Will get around to it as soon as Travis gives the green light.
sinhrks
added
Strings
Current coverage is 84.52%@@ master #13701 diff @@
==========================================
Files 141 141
Lines 51145 51144 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43233 43232 -1
Misses 7912 7912
Partials 0 0
|
gfyoung
force-pushed
the
series-return-type-remove
branch
from
375ed6a
to
a8ea397
Compare
|
@sinhrks : Made the requested doc change (hence the |
| @@ -1906,45 +1906,6 @@ def test_split_no_pat_with_nonzero_n(self): | |||
|
|
|||
| def test_split_to_dataframe(self): | |||
| s = Series(['nosplit', 'alsonosplit']) | |||
|
|
|||
| with tm.assert_produces_warning(FutureWarning): | |||
There was a problem hiding this comment.
these should still work w/o the argument, so leave the tests themselves
There was a problem hiding this comment.
They are duplicates essentially with the tests that follow, which is why I removed them.
gfyoung
force-pushed
the
series-return-type-remove
branch
from
a8ea397
to
38531c2
Compare
|
Thanks! |
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues where #10085 left off by removing the
return_typeparameter for good.