-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR/DOC: rpy deprecation #9602
Comments
I put some todo's above. |
Regarding the second item in the list, rpy2 currently does not handle missing values correctly, a NaN value will remain NaN in R and not be considered a missing value (NA). The function pandas.rpy.common.convert_to_r_dataframe performed the conversion correctly. |
@jreback I moved this to 0.16.1 milestone: I think we should at least have a link the deprecation warning to the docs, where a minimal link is how to port your code. This minimal thing should not be much work, and I will do it this week. |
Thanks for highlighting this Aurélien. Is there an issue on the rpy2 issue
|
+1 |
Not that I know of; or my Google-fu failed me. |
I opened an issue at rpy2 to track this there as well: https://bitbucket.org/rpy2/rpy2/issue/282/missing-features-in-rpy2s-pandas2ri The solution is to improve |
@jorisvandenbossche The issue in the link (issue 282 on rpy2's issue tracker on bitbucket) has been closed. |
@lgautier Great! thanks for all your hard work on this and other Rpy2 stuff :) |
@jorisvandenbossche did we remove this? |
No, we did not yet remove this, because there are (or were, should be checked) still some issues with the rpy2 alternative that were better supported in the pandas version. Needs someone to go over this (but ideally someone who uses |
@jorisvandenbossche Unless the issues are reported in the |
It's my preference to deprecate |
@wesm It's already deprecated for a couple of releases, and we indeed should certainly remove it. At the time of deprecation, there were still some issues in |
Was looking into this today, but ran into some issues converting simple dataframes, reported here: https://bitbucket.org/rpy2/rpy2/issues/394/pandas2ripy2ri-on-basic-dataframe-falls But in any case, will put up a PR to remove the module. |
Being gnomish - the above issue has resolved to a documentation issue. |
so we should put up a deprecation notice on
rpy
imports that in the future the user should userpy2
directly rather than the less-supportedpandas.rpy
converters that we can take action say in 0.17.0discussed extensivley in #7385
xref #7385, #9187 #7309, #8255
rpy2
API -> done with DOC/DEPR: port pandas.rpy to rpy2 guide #10075rpy2
(what still works better in pandas?)ri2py
-> this should be handled in https://bitbucket.org/rpy2/rpy2/issues/285rpy2
?The text was updated successfully, but these errors were encountered: