Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y-high-contrast-light errors showing up in Sphinx on main #1081

Closed
choldgraf opened this issue Dec 14, 2022 · 3 comments · Fixed by #1083
Closed

a11y-high-contrast-light errors showing up in Sphinx on main #1081

choldgraf opened this issue Dec 14, 2022 · 3 comments · Fixed by #1083
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working

Comments

@choldgraf
Copy link
Collaborator

I am trying to get some improvements into the sphinx-book-theme using main from this theme, and finding this error message that keeps popping up:

E         + WARNING: Color theme a11y-high-contrast-light not found by pygments, falling back to tango.
E         + WARNING: Color theme a11y-high-contrast-dark not found by pygments, falling back to monokai.

Any idea why this would be happening? cc @drammock who authored the PR where I believe these were added:

@choldgraf choldgraf added the kind: bug Something isn't working label Dec 14, 2022
@choldgraf
Copy link
Collaborator Author

Ah I think this is because we only installed the accessible-pygments package in our doc environment, it's not a dependency:

https://github.com/pydata/pydata-sphinx-theme/pull/1064/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R54

My feeling is that we want the default install to not build with any warnings, so we should either make accessible-pygments a dependency of the theme, or we should remove the warning and default to not using accessible-pygments.

@choldgraf choldgraf added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Dec 14, 2022
@drammock
Copy link
Collaborator

oops. yeah, I think you've diagnosed correctly. I should have added it as a full dependency, not just for doc.

@drammock
Copy link
Collaborator

i'll open a quick PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants