Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dark mode] Tables have light background and low contrast #1543

Closed
choldgraf opened this issue Oct 26, 2023 · 3 comments · Fixed by #1546
Closed

[dark mode] Tables have light background and low contrast #1543

choldgraf opened this issue Oct 26, 2023 · 3 comments · Fixed by #1546
Assignees
@12rambau
Labels
kind: bug Something isn't working

Comments

@choldgraf
Copy link
Collaborator

The API documentation page has tables with a light and low-contrast background in dark-mode. For example:

CleanShot 2023-10-26 at 15 59 17@2x

From this page:

https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/api.html
@choldgraf choldgraf added the kind: bug Something isn't working label Oct 26, 2023
@choldgraf choldgraf mentioned this issue Oct 26, 2023
Open
@casperdcl
Copy link
Contributor

Yes was working fine in v0.14.1 but broke in v0.14.2

casperdcl added a commit to premAI-io/state-of-open-source-ai that referenced this issue Oct 27, 2023
@casperdcl
fix dark mode
ef18e55 
- vis. pydata/pydata-sphinx-theme#1543
@casperdcl casperdcl mentioned this issue Oct 27, 2023
Merged
@scott-huberty scott-huberty mentioned this issue Oct 27, 2023
Closed
@12rambau
Copy link
Collaborator

As 0.14.2 allowed us to make a jump from Sphinx 5 to Sphinx 7 I guess we missed some class updates ;-)

@krassowski
Copy link

This affects all tables, not only API tables, for example:

image

It indeed worked fine in 0.14.1 and broke in 0.14.2.

@krassowski krassowski mentioned this issue Oct 29, 2023
Closed
@choldgraf choldgraf changed the title [dark mode] API documentation tables have light background [dark mode] Tables have light background and low contrast Oct 29, 2023
@drammock drammock mentioned this issue Oct 30, 2023
Merged
5 tasks
@12rambau 12rambau self-assigned this Oct 30, 2023
@12rambau 12rambau mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@12rambau 12rambau

Labels
kind: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make table background transparent 12rambau/pydata-sphinx-theme
4 participants
@choldgraf @krassowski @casperdcl @12rambau