-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine our inline code style #837
Comments
For me this code styling was the pandas documentation signature but I also know that people find it disturbing. I'm perfectly happy with the solution that use "color primary" as it continues to stand out. |
I don't mind adding a background to inline code spans. I'm not a big fan of putting borders around it though. If it must have borders please make them very subtle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Currently we are using the default Bootstrap style for inline code:
This is an issue to discuss whether people prefer a different kind of style.
I think the most common alternative would be something that also defines a background to the inline code span, to make it stand out a bit more, and feel more similar to code blocks. A few examples from our inspiration themes:
After digging up all of these examples, I promise I didn't know this ahead of time but it looks like all of them define a background for their inline code. Maybe we should consider doing the same?
Example
I did a quick experiment, and if we add the following CSS lines:
We get this effect:
Or with color primary:
The text was updated successfully, but these errors were encountered: